Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files_sharing: Add OpenAPI spec #39330

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

provokateurin
Copy link
Member

Summary

From #36666. Adds the necessary annotations and descriptions.

Checklist

@@ -328,23 +331,29 @@
$result['share_with_displayname'] = '';

try {
$result = array_merge($result, $this->getRoomShareHelper()->formatShare($share));
/** @var array{share_with_displayname: string, share_with_link: string, share_with?: string, token?: string} $roomShare */
$roomShare = $this->getRoomShareHelper()->formatShare($share);

Check notice

Code scanning / Psalm

UndefinedDocblockClass

Docblock-defined class, interface or enum named OCA\Talk\Share\Helper\ShareAPIController does not exist
@provokateurin provokateurin force-pushed the feature/openapi/files_sharing branch from 3b18997 to 5a096bf Compare July 31, 2023 14:23
@provokateurin provokateurin marked this pull request as ready for review July 31, 2023 14:24
@provokateurin provokateurin enabled auto-merge July 31, 2023 14:24
@provokateurin provokateurin force-pushed the feature/openapi/files_sharing branch from 5a096bf to c680668 Compare July 31, 2023 14:59
@provokateurin provokateurin merged commit 30345f8 into master Aug 1, 2023
@provokateurin provokateurin deleted the feature/openapi/files_sharing branch August 1, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants