Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customer support link in the short footer #39291

Closed
wants to merge 1 commit into from
Closed

Add customer support link in the short footer #39291

wants to merge 1 commit into from

Conversation

aaygupta
Copy link

@aaygupta aaygupta commented Jul 10, 2023

Summary

Add customer support link in the short footer, add translations for en_GB, update tests.
image

TODO

  • Update Documentation
  • Add Translations in other languages

@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Jul 10, 2023
@kesselb
Copy link
Contributor

kesselb commented Jul 10, 2023

Hi @aaygupta 👋

Thanks for your great contribution 👍

  • Please revert the changes to the translations. We use transifx to manage translations. A background job will extract the source strings, push them to transifex and pull back the translations later.
  • Please commit the changes to dist/theming-admin-theming.js and dist/theming-admin-theming.js.map

apps/theming/lib/ThemingDefaults.php Outdated Show resolved Hide resolved
apps/theming/lib/ThemingDefaults.php Outdated Show resolved Hide resolved
apps/theming/src/AdminTheming.vue Outdated Show resolved Hide resolved
@aaygupta
Copy link
Author

Hi @kesselb, all the mentioned changes have been made.

Regards
Ankit Gupta

apps/theming/lib/ThemingDefaults.php Outdated Show resolved Hide resolved
@kesselb kesselb requested review from a team, susnux, Pytal and szaimen and removed request for a team July 11, 2023 09:54
@kesselb kesselb added this to the Nextcloud 28 milestone Jul 11, 2023
@szaimen szaimen removed their request for review July 11, 2023 09:57
@kesselb
Copy link
Contributor

kesselb commented Jul 11, 2023

Index: apps/theming/tests/ThemingDefaultsTest.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/apps/theming/tests/ThemingDefaultsTest.php b/apps/theming/tests/ThemingDefaultsTest.php
--- a/apps/theming/tests/ThemingDefaultsTest.php	(revision e31716151ba4e4a35e1d35089fd0a6966f10d1d8)
+++ b/apps/theming/tests/ThemingDefaultsTest.php	(date 1689084570187)
@@ -831,6 +831,7 @@
 				['theming', 'faviconMime', '', 'jpeg'],
 				['theming', 'color', '', $this->defaults->getColorPrimary()],
 				['theming', 'color', $this->defaults->getColorPrimary(), $this->defaults->getColorPrimary()],
+				['theming', 'supportUrl', '', ''],
 			]);
 
 		$this->util->expects($this->any())->method('invertTextColor')->with($this->defaults->getColorPrimary())->willReturn(false);

For the failing test.
The string type cast for the getPrivacyUrl and getImprintUrl hide that we don't mock them properly in the test case.

Could you pull in the latest changes from master and recompile the assets again? To have the latest changes.

@aaygupta
Copy link
Author

Hi @kesselb I have rebased the branch.

@kesselb kesselb requested review from skjnldsv and szaimen July 13, 2023 20:15
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
@szaimen
Copy link
Contributor

szaimen commented Mar 12, 2024

Conflicts...

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 12, 2024
@Altahrim
Copy link
Collaborator

@aaygupta Can you update the PR please?
You'll have to rebase, fix conflicts and use conventional commits

This was referenced Mar 14, 2024
@Altahrim Altahrim mentioned this pull request Mar 25, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@aaygupta aaygupta closed this by deleting the head repository Jul 10, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the link to IT/Customer Support
7 participants