-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable27] fix(cypress): branch definition #39067
Conversation
Signed-off-by: John Molakvoæ <[email protected]>
3ca1585
to
772aa81
Compare
/backport to stable26 |
/backport to master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦭
Seems to work! +1
Saw that also in my backport: https://github.com/nextcloud/server/actions/runs/5409725309/jobs/9833992543?pr=39055#step:5:146
Let's see if it will help
This is a different issue :)
|
Signed-off-by: John Molakvoæ <[email protected]>
5ec1434
to
16c7c07
Compare
Maybe not, let's see |
https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
Explanation
The trick is that
github.base_ref
is only set when the workflow was triggered by apull_request
and it contains the value of the source branch of the PR.github.ref_name
will than only be used if the workflow was not triggered by apull_request
and it also just contains the branch name.GitHub Documentation
Detailed explanation from official GitHub docs: