Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] Store encrypted OAuth2 client secrets #38707

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

julien-nc
Copy link
Member

@julien-nc julien-nc commented Jun 8, 2023

Manual backport of #38398 and #38701

I kept the original migration version so it does not reflect the actual app version.

@julien-nc julien-nc added 3. to review Waiting for reviews security labels Jun 8, 2023
@julien-nc julien-nc added this to the Nextcloud 27 milestone Jun 8, 2023
@julien-nc julien-nc requested a review from ChristophWurst as a code owner June 8, 2023 12:20
return null;
}

public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\OAuth2\Migration\Version011601Date20230522143227::postSchemaChange does not have a return type, expecting void
@julien-nc julien-nc force-pushed the backport/38398/stable27 branch from 715cce9 to 0c9ccb2 Compare June 9, 2023 08:28
@julien-nc julien-nc requested review from kesselb, szaimen, a team, ArtificialOwl, icewind1991 and nfebe and removed request for a team June 9, 2023 08:29
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz blizzz mentioned this pull request Jun 12, 2023
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julien-nc julien-nc force-pushed the backport/38398/stable27 branch 2 times, most recently from f1b7112 to 39beecd Compare June 12, 2023 15:11
@julien-nc julien-nc requested a review from ChristophWurst June 12, 2023 15:14
@julien-nc julien-nc force-pushed the backport/38398/stable27 branch 2 times, most recently from 303537b to 8d72c77 Compare June 19, 2023 09:04
@julien-nc
Copy link
Member Author

Failing Cypress tests are related with files_versions and theming.
https://github.com/nextcloud/server/actions/runs/5309936925/jobs/9611378026?pr=38707

@julien-nc julien-nc force-pushed the backport/38398/stable27 branch from 8d72c77 to c18e42f Compare June 19, 2023 11:12
@julien-nc julien-nc merged commit d1aa03a into stable27 Jun 19, 2023
@julien-nc julien-nc deleted the backport/38398/stable27 branch June 19, 2023 11:12
@blizzz blizzz mentioned this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants