Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some dead code in files app #38332

Merged
merged 1 commit into from
May 19, 2023
Merged

Remove some dead code in files app #38332

merged 1 commit into from
May 19, 2023

Conversation

pulsejet
Copy link
Member

No clue what this is doing, but it's never used anywhere (the debounced function doesn't exist to begin with)
Pl close if I'm wrong and this is actually useful.

@pulsejet pulsejet added 3. to review Waiting for reviews technical debt php Pull requests that update Php code labels May 17, 2023
@juliusknorr juliusknorr added javascript and removed php Pull requests that update Php code labels May 17, 2023
@juliusknorr juliusknorr requested review from a team, susnux, nfebe and szaimen and removed request for a team May 17, 2023 06:48
@juliusknorr juliusknorr added this to the Nextcloud 28 milestone May 17, 2023
@juliusknorr
Copy link
Member

juliusknorr commented May 17, 2023

DCO check is failing, can you sign-off the commit?

@szaimen szaimen removed their request for review May 17, 2023 07:39
@susnux
Copy link
Contributor

susnux commented May 17, 2023

Was removed in NC26 by @skjnldsv (5c987a0)

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just please sign your comment message

@pulsejet pulsejet force-pushed the pulsejet/patch-dead1 branch from 037695d to 262c84a Compare May 17, 2023 16:57
@pulsejet
Copy link
Member Author

Done

@szaimen
Copy link
Contributor

szaimen commented May 19, 2023

CI failure unrelated

@szaimen szaimen merged commit 8cca865 into master May 19, 2023
@szaimen szaimen deleted the pulsejet/patch-dead1 branch May 19, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants