Convert Add group link to button #38202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
fix/37135/addgroup-link-to-button
branch
from
1c77203 to
6ae4495
Compare
nfebe
force-pushed
the
fix/37135/addgroup-link-to-button
branch
3 times, most recently
from
473f54c to
b862829
Compare
nfebe
changed the title
|
I believe this would have to be completed in nextcloud/nextcoud-vue but that this is a step towards the intended outcome. |
The "Add group" peforms an on-page action and does not route or link to anywhere else hence, not semantically a link but a button. This commit implements the ehancement described at the respository level. A change would be required in [@nextcloud/nextcloud-vue](nextcloud-libraries/nextcloud-vue#4108) since the `NcAppNavigationNewItem` is an out-of-repo dependency. Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
fix/37135/addgroup-link-to-button
branch
from
b862829 to
1ee8fba
Compare
artonge
approved these changes
May 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert "Add group" action to button instead of link since it does not have a "route" but just an on-page action.
Checklist
Before
After