Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change maintenance mode info wording #37925

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Apr 25, 2023

  • Resolves: #

Summary

Nextcloud is in maintenance mode, hence the database isn't accessible.
Cannot perform any command except 'maintenance:mode --off'

A customer brought to our attention that the message is misleading.

In maintenance mode the database is accessible and it's possible to execute other commands then maintenance:mode

image

The reason we changed the message was #20515.
I restored the old wording and added another line to make clear that some commands are unavailable.

TODO

  • ...

Checklist

@kesselb kesselb force-pushed the feat-update-maintenance-mode-hint branch from 452ece9 to 2f73260 Compare April 25, 2023 18:09
@kesselb kesselb marked this pull request as ready for review April 25, 2023 18:09
@kesselb kesselb self-assigned this Apr 25, 2023
@kesselb kesselb added 3. to review Waiting for reviews technical debt labels Apr 25, 2023
@kesselb kesselb force-pushed the feat-update-maintenance-mode-hint branch from 2f73260 to 7727775 Compare April 25, 2023 18:52
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That indeed looks like a better wording, thanks!

@szaimen szaimen added this to the Nextcloud 27 milestone Apr 25, 2023
In maintenance mode the database is accessible and it's possible to execute other commands then maintenance:mode

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the feat-update-maintenance-mode-hint branch from 7727775 to 155ea6a Compare April 26, 2023 09:58
@szaimen szaimen enabled auto-merge April 26, 2023 10:42
@kesselb kesselb disabled auto-merge April 26, 2023 11:55
@kesselb kesselb merged commit 81e4390 into master Apr 26, 2023
@kesselb kesselb deleted the feat-update-maintenance-mode-hint branch April 26, 2023 11:55
@kesselb
Copy link
Contributor Author

kesselb commented Apr 26, 2023

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@solracsf
Copy link
Member

solracsf commented May 1, 2023

/backport to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants