-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invalidate oauth2 tokens only for seen users #37761
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
blizzz,
a team,
ArtificialOwl and
icewind1991
and removed request for
a team
April 17, 2023 07:34
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
individual-it
force-pushed
the
invalidateTokensOnlySeenUsers
branch
from
May 19, 2023 07:09
22cf072
to
572e2b6
Compare
Due to the branchoff this week, it also needs a backport to stable27. |
icewind1991
approved these changes
Jun 3, 2023
@icewind1991 I'm not clear what to do with this. @blizzz said in #37230 (comment) that it should go in a background job |
Merged
AndyScherzinger
force-pushed
the
invalidateTokensOnlySeenUsers
branch
from
February 27, 2024 13:20
572e2b6
to
dec5383
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
9 tasks
skjnldsv
added
2. developing
Work in progress
stale
Ticket or PR with no recent activity
and removed
3. to review
Waiting for reviews
labels
Jul 27, 2024
Merged
Signed-off-by: Artur Neumann <[email protected]>
Signed-off-by: Artur Neumann <[email protected]>
skjnldsv
force-pushed
the
invalidateTokensOnlySeenUsers
branch
from
August 16, 2024 08:34
dec5383
to
84ee79f
Compare
skjnldsv
added
4. to release
Ready to be released and/or waiting for tests to finish
bug
and removed
2. developing
Work in progress
stale
Ticket or PR with no recent activity
labels
Aug 16, 2024
skjnldsv
approved these changes
Aug 16, 2024
This is an old PR, but should be alright! Thank you for the great work @individual-it 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up PR for #36033 to make sure tokens are deleted only for seen users, see discussion in #37230 (comment)
CC @blizzz
Checklist