Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalidate oauth2 tokens only for seen users #37761

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

individual-it
Copy link
Contributor

@individual-it individual-it commented Apr 17, 2023

Summary

This is a follow-up PR for #36033 to make sure tokens are deleted only for seen users, see discussion in #37230 (comment)

CC @blizzz

Checklist

@szaimen szaimen added this to the Nextcloud 27 milestone Apr 17, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label Apr 17, 2023
@szaimen szaimen requested review from blizzz, a team, ArtificialOwl and icewind1991 and removed request for a team April 17, 2023 07:34
This was referenced May 3, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
@individual-it individual-it force-pushed the invalidateTokensOnlySeenUsers branch from 22cf072 to 572e2b6 Compare May 19, 2023 07:09
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 19, 2023
@blizzz
Copy link
Member

blizzz commented May 19, 2023

Due to the branchoff this week, it also needs a backport to stable27.

@individual-it
Copy link
Contributor Author

@icewind1991 I'm not clear what to do with this. @blizzz said in #37230 (comment) that it should go in a background job

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@AndyScherzinger AndyScherzinger force-pushed the invalidateTokensOnlySeenUsers branch from 572e2b6 to dec5383 Compare February 27, 2024 13:20
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsv skjnldsv reopened this Aug 16, 2024
@skjnldsv skjnldsv force-pushed the invalidateTokensOnlySeenUsers branch from dec5383 to 84ee79f Compare August 16, 2024 08:34
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish bug and removed 2. developing Work in progress stale Ticket or PR with no recent activity labels Aug 16, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Aug 16, 2024

This is an old PR, but should be alright!
Le me take over and help get this in for 31!

Thank you for the great work @individual-it 💪

@skjnldsv skjnldsv self-assigned this Aug 16, 2024
@skjnldsv skjnldsv merged commit b8dbed3 into master Aug 16, 2024
169 of 170 checks passed
@skjnldsv skjnldsv deleted the invalidateTokensOnlySeenUsers branch August 16, 2024 10:17
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: authentication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: deleting oauth client does not delete the tokes given out by the client
6 participants