Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow searching for favorites #3772

Merged
merged 1 commit into from
Mar 13, 2017
Merged

Allow searching for favorites #3772

merged 1 commit into from
Mar 13, 2017

Conversation

icewind1991
Copy link
Member

Using

<d:eq>
     <d:prop>
          <oc:favorite/>
     </d:prop>
     <d:literal>yes</d:literal>
</d:eq>

As part of the search query

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 8, 2017
@icewind1991 icewind1991 added this to the Nextcloud 12.0 milestone Mar 8, 2017
@mention-bot
Copy link

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FlorinPeter, @butonic and @nickvergessen to be potential reviewers.

Signed-off-by: Robin Appelman <[email protected]>
@MorrisJobke
Copy link
Member

@mario Is this the only change needed for the android app or is there more to come?

@mario
Copy link
Contributor

mario commented Mar 9, 2017

@MorrisJobke I won't know until I start working on "Recently modified" and stuff like that. But maybe I can workaround it for now and not require more server changes...

@mario
Copy link
Contributor

mario commented Mar 9, 2017

👍 - works as advertised.

@mario
Copy link
Contributor

mario commented Mar 10, 2017

@icewind1991 two more questions/requests:

  1. Searching for shared files/folders
  2. Searching by date created (uploaded?) if creationdate is the right attribute?

Would appreciate it, otherwise I have to do propfind and do it manually...

@mario
Copy link
Contributor

mario commented Mar 10, 2017

@nickvergessen told me that creationdate isn't the right thing for no. 2 requirement. Please link me up when you get the time to relevant issue.

I still need both somehow implemented though.

@mario
Copy link
Contributor

mario commented Mar 12, 2017

  1. So to clarify my first requirement:

All files shared by you, with you, and by link, in a single flat list.

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit f7cef9f into master Mar 13, 2017
@MorrisJobke MorrisJobke deleted the favorite-search branch March 13, 2017 06:55
@MorrisJobke
Copy link
Member

@mario Please open separate issues for your requests. And is this now all for the search feature? Or is there still something missing on the server side?

@mario
Copy link
Contributor

mario commented Mar 13, 2017

@MorrisJobke I opened three relevant issues, and we'll see if it can be achieved using existing implementation or not.

@MorrisJobke MorrisJobke mentioned this pull request Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants