-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow searching for favorites #3772
Conversation
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FlorinPeter, @butonic and @nickvergessen to be potential reviewers. |
Signed-off-by: Robin Appelman <[email protected]>
53368cd
to
e61606a
Compare
@mario Is this the only change needed for the android app or is there more to come? |
@MorrisJobke I won't know until I start working on "Recently modified" and stuff like that. But maybe I can workaround it for now and not require more server changes... |
👍 - works as advertised. |
@icewind1991 two more questions/requests:
Would appreciate it, otherwise I have to do propfind and do it manually... |
@nickvergessen told me that creationdate isn't the right thing for no. 2 requirement. Please link me up when you get the time to relevant issue. I still need both somehow implemented though. |
All files shared by you, with you, and by link, in a single flat list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
@mario Please open separate issues for your requests. And is this now all for the search feature? Or is there still something missing on the server side? |
@MorrisJobke I opened three relevant issues, and we'll see if it can be achieved using existing implementation or not. |
Using
As part of the search query