-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop IEventListener template parameter #37506
Conversation
See vimeo/psalm#7549 |
I see, so the type hint will actually be useful? |
Hopefully some day. I never found a way to make it work properly. |
Hm so we either keep it and the changes in this PR to make it work in the future, or we completely drop it now since it doesn't work. I'd go with the second option, what do you think @come-nc @ChristophWurst ? |
What happens if you keep your changes except for the ones in lib/public/EventDispatcher/IEventListener.php ? |
I think that'll work and have no effect as expected. |
Signed-off-by: jld3103 <[email protected]>
85d542e
to
fb99e51
Compare
@come-nc @ChristophWurst please review again. |
Summary
Split out from #37390
Checklist