Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from SETEX to SET EX #37350

Closed
wants to merge 3 commits into from
Closed

Move from SETEX to SET EX #37350

wants to merge 3 commits into from

Conversation

solracsf
Copy link
Member

Summary

SETEX is depreacted and may be removed: https://redis.io/commands/setex/
PHPredis handles the redirection if needed: https://github.com/phpredis/phpredis#set

(+) small code optimizations

Checklist

Signed-off-by: Git'Fellow <[email protected]>
@solracsf solracsf added the 3. to review Waiting for reviews label Mar 22, 2023
@solracsf solracsf added this to the Nextcloud 27 milestone Mar 22, 2023
@solracsf solracsf changed the title Move from SETEXT to SET EX Move from SETEX to SET EX Mar 22, 2023
@solracsf solracsf requested review from come-nc and juliusknorr March 22, 2023 16:16
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid mixing changes and refactoring in a single commit like this, it took me a long time to spot the actual change.
Mixing them in a same PR is fine but at least split the commits.

@solracsf
Copy link
Member Author

Please avoid mixing changes and refactoring in a single commit like this, it took me a long time to spot the actual change. Mixing them in a same PR is fine but at least split the commits.

Noted.

This was referenced May 3, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
@solracsf solracsf closed this Nov 1, 2023
@skjnldsv skjnldsv deleted the setex-depr branch March 14, 2024 07:51
@skjnldsv skjnldsv removed this from the Nextcloud 28 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants