Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add important to css hidden files class #37269

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix: add important to css hidden files class #37269

merged 1 commit into from
Mar 17, 2023

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Mar 16, 2023 •
edited
Loading

Summary

Class conflicts lead to hidden files being shown. Quick'n'dirty to hide hidden files as tested by @kesselb

Checklist

@miaulalala miaulalala requested review from skjnldsv and kesselb March 16, 2023 16:42
@miaulalala miaulalala self-assigned this Mar 16, 2023
@miaulalala miaulalala added 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. labels Mar 16, 2023
szaimen
szaimen approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Thanks a lot for fixing this! :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 17, 2023
@miaulalala miaulalala force-pushed the fix/scss-add-important-to-hidden-file-class branch from 91008de to c9a18fc Compare March 17, 2023 11:41
@miaulalala
Copy link
Contributor Author

/backport to stable26

@miaulalala
Copy link
Contributor Author

/backport to stable25

@szaimen szaimen added this to the Nextcloud 27 milestone Mar 17, 2023
@szaimen szaimen enabled auto-merge March 17, 2023 11:44
@szaimen szaimen merged commit 0b4f4a1 into master Mar 17, 2023
@szaimen szaimen deleted the fix/scss-add-important-to-hidden-file-class branch March 17, 2023 13:41
This was referenced Mar 17, 2023
Merged
Merged
@Jerome-Herbinet Jerome-Herbinet mentioned this pull request Apr 5, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@szaimen szaimen szaimen approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@miaulalala miaulalala

Labels
4. to release Ready to be released and/or waiting for tests to finish papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.

[Bug]: Hidden files visible in Grid View mode
3 participants
@miaulalala @skjnldsv @szaimen