Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(references): Do not log errors on 404 responses of opengraph image fetching #37198

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

juliusknorr
Copy link
Member

Avoid error logging for a case that is expected when the opengraph image is not available

@juliusknorr juliusknorr requested review from julien-nc, a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team March 13, 2023 17:19
@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Mar 13, 2023
@juliusknorr juliusknorr added this to the Nextcloud 27 milestone Mar 13, 2023
@juliusknorr
Copy link
Member Author

/backport to stable26

@nickvergessen nickvergessen merged commit 6741b37 into master Mar 27, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/reference-image-log branch March 27, 2023 11:56
@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants