Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessible system tags select #37065

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Add accessible system tags select #37065

merged 3 commits into from
Apr 20, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Mar 7, 2023

Summary

Before After
image image
image image
Notes

FIXMEs are out-of-scope

The parseIdFromLocation() util was adapted from

function parseIdFromLocation(url) {
var queryPos = url.indexOf('?')
if (queryPos > 0) {
url = url.substr(0, queryPos)
}
var parts = url.split('/')
var result
do {
result = parts[parts.length - 1]
parts.pop()
// note: first result can be empty when there is a trailing slash,
// so we take the part before that
} while (!result && parts.length > 0)
return result
}

TODO

Checklist

@blizzz
Copy link
Member

blizzz commented Mar 7, 2023

master is 27

@Pytal Pytal force-pushed the enh/a11y-system-tags branch 2 times, most recently from 36fd841 to d696ea8 Compare March 16, 2023 17:06
@Pytal Pytal force-pushed the enh/a11y-system-tags branch from d696ea8 to d8ea161 Compare March 31, 2023 01:50
@Pytal Pytal force-pushed the enh/a11y-system-tags branch from d8ea161 to a94adf0 Compare April 12, 2023 03:53
@Pytal Pytal changed the title [WIP] Port system tags select Add accessible system tags select Apr 12, 2023
@Pytal Pytal added enhancement 3. to review Waiting for reviews feature: tags accessibility and removed 2. developing Work in progress labels Apr 12, 2023
@Pytal

This comment was marked as outdated.

@Pytal Pytal marked this pull request as ready for review April 12, 2023 04:13
@Pytal Pytal force-pushed the enh/a11y-system-tags branch 6 times, most recently from 6018d67 to b3fdc6b Compare April 14, 2023 21:51
@Pytal Pytal force-pushed the enh/a11y-system-tags branch from b3fdc6b to 9f6056a Compare April 18, 2023 01:34
Pytal added 3 commits April 19, 2023 16:52
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal force-pushed the enh/a11y-system-tags branch from 9f6056a to 177849c Compare April 19, 2023 23:52
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 19, 2023
@Pytal Pytal merged commit 09cb9c7 into master Apr 20, 2023
@Pytal Pytal deleted the enh/a11y-system-tags branch April 20, 2023 01:20
pulsejet added a commit that referenced this pull request Oct 17, 2023
With #37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).

This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.

Signed-off-by: Varun Patil <[email protected]>
nextcloud-command pushed a commit that referenced this pull request Oct 17, 2023
With #37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).

This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.

Signed-off-by: Varun Patil <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
pulsejet added a commit that referenced this pull request Oct 17, 2023
With #37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).

This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.

Signed-off-by: Varun Patil <[email protected]>
pulsejet added a commit that referenced this pull request Nov 27, 2023
With #37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).

This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.

Signed-off-by: Varun Patil <[email protected]>
nextcloud-command pushed a commit that referenced this pull request Nov 27, 2023
With #37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).

This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.

Signed-off-by: Varun Patil <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
zak39 pushed a commit to zak39/server that referenced this pull request Dec 19, 2023
With nextcloud#37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).

This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.

Signed-off-by: Varun Patil <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
backportbot bot pushed a commit that referenced this pull request Jan 15, 2024
With #37065, there is no way to hide the tags from the sidebar

by default when they are not relevant or redundant (e.g. the tab

may already show the file's tags). This can be annyoing especially

when the file has many tags. This patch adds an option to hide

the tags from the sidebar by default (the user can still open

the tags tab manually).

This also reduces one request when opening the sidebar when the

tags are turned off, since all tags don't need to be fetched

anymore.

Signed-off-by: Varun Patil <[email protected]>

Signed-off-by: nextcloud-command <[email protected]>

[skip ci]
nextcloud-command pushed a commit that referenced this pull request Jul 4, 2024
With #37065, there is no way to hide the tags from the sidebar

by default when they are not relevant or redundant (e.g. the tab

may already show the file's tags). This can be annyoing especially

when the file has many tags. This patch adds an option to hide

the tags from the sidebar by default (the user can still open

the tags tab manually).

This also reduces one request when opening the sidebar when the

tags are turned off, since all tags don't need to be fetched

anymore.

Signed-off-by: Varun Patil <[email protected]>

Signed-off-by: nextcloud-command <[email protected]>

Signed-off-by: nextcloud-command <[email protected]>
solracsf pushed a commit that referenced this pull request Jul 5, 2024
With #37065, there is no way to hide the tags from the sidebar

by default when they are not relevant or redundant (e.g. the tab

may already show the file's tags). This can be annyoing especially

when the file has many tags. This patch adds an option to hide

the tags from the sidebar by default (the user can still open

the tags tab manually).

This also reduces one request when opening the sidebar when the

tags are turned off, since all tags don't need to be fetched

anymore.

Signed-off-by: Varun Patil <[email protected]>

Signed-off-by: nextcloud-command <[email protected]>

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement feature: tags
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants