Don't regard 1024px width viewport as mobile #36751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css). This commit changes `mobile.scss` to treat viewports smaller than 1024px as mobile. This PR accompanies nextcloud-libraries/nextcloud-vue#3768 Both are required to fix nextcloud-libraries/nextcloud-vue#3758. Signed-off-by: Jonas <[email protected]>
mejo-
requested review from
ChristophWurst,
raimund-schluessler,
juliusknorr and
skjnldsv
mejo-
added a commit
to nextcloud-libraries/nextcloud-vue
that referenced
this pull request
Feb 16, 2023
* In IsMobileState.js we treat viewports smaller 1024px as mobile. * In NcAppContent.vue we treat viewports starting with 1024px as mobile. This results in weird behaviour with screens that have exactly 1024px width. E.g., on three-pane apps, NcAppContentList is hidden but the NcAppDetailsToggle button is not displayed yet. This commit changes NcAppContent.vue to treat viewports smaller 1024px as mobile, to be in sync with IsMobileState.js. This PR accompanies nextcloud/server#36751. Both are required to fix #3758. Fixes: #3758 Signed-off-by: Jonas <[email protected]>
This was referenced Feb 16, 2023
ChristophWurst
approved these changes
Feb 16, 2023
|
/backport to stable25 |
max-nextcloud
approved these changes
Feb 17, 2023
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we treat 1024px as mobile in some places (e.g.
isMobilein nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).This commit changes
mobile.scssto treat viewports smaller than 1024px as mobile.This PR accompanies nextcloud-libraries/nextcloud-vue#3768
Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.