Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty DB while expiring versions #36556

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Feb 6, 2023

Version on the FS can have no equivalent in the DB if they were created before the version naming feature. This makes sure that we catch the resulting exception and proceed as usual.

Fix #36541

@artonge artonge self-assigned this Feb 6, 2023
@artonge artonge added 26-feedback bug feature: versions php Pull requests that update Php code labels Feb 6, 2023
@artonge artonge added this to the Nextcloud 26 milestone Feb 6, 2023
@artonge artonge force-pushed the artonge/fix/expiring_file_versions_empty_db branch 2 times, most recently from 633712a to 0dd8c91 Compare February 6, 2023 09:47
@artonge artonge changed the title Artonge/fix/expiring_file_versions_empty_db Handle empty DB while expiring versions Feb 6, 2023
@artonge artonge added the 3. to review Waiting for reviews label Feb 6, 2023
@artonge
Copy link
Contributor Author

artonge commented Feb 8, 2023

/rebase

@artonge artonge requested review from a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team February 8, 2023 13:48
Version on the FS can have no equivalent in the DB if they were created before the version naming feature. This makes sure that we catch the resulting exception and proceed as usual.

Fix #36541

Signed-off-by: Louis Chemineau <[email protected]>
@nextcloud-command nextcloud-command force-pushed the artonge/fix/expiring_file_versions_empty_db branch from 0dd8c91 to 21cd3b0 Compare February 8, 2023 13:56
@blizzz blizzz requested a review from nickvergessen February 16, 2023 12:38
@blizzz blizzz mentioned this pull request Feb 16, 2023
@blizzz blizzz requested review from szaimen and come-nc February 16, 2023 12:55
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz blizzz merged commit fdc64b1 into master Feb 16, 2023
@blizzz blizzz deleted the artonge/fix/expiring_file_versions_empty_db branch February 16, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews 26-feedback bug feature: versions php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: NC 26.0.0beta2 cron.php triggers OCP\\AppFramework\\Db\\DoesNotExistException
4 participants