Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imaginary - fix generation of heif, pdf, illustrator and svg thumbnails #36546

Merged
merged 1 commit into from
Feb 8, 2023
Merged

imaginary - fix generation of heif, pdf, illustrator and svg thumbnails #36546

merged 1 commit into from
Feb 8, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Feb 5, 2023 •
edited
Loading

@szaimen szaimen added the 2. developing Work in progress label Feb 5, 2023
@szaimen szaimen added this to the Nextcloud 26 milestone Feb 5, 2023
@szaimen szaimen force-pushed the enh/36543/allow-further-previews branch 6 times, most recently from e15b562 to a223d08 Compare February 5, 2023 16:11
@szaimen szaimen changed the title imaginary - allow to generate heif, pdf and svg thumbnails imaginary - fix generation of heif, pdf and svg thumbnails Feb 5, 2023
@szaimen szaimen added the bug label Feb 5, 2023
@szaimen szaimen force-pushed the enh/36543/allow-further-previews branch 3 times, most recently from 7c7dd6f to 277c467 Compare February 7, 2023 22:45
@szaimen szaimen changed the title imaginary - fix generation of heif, pdf and svg thumbnails imaginary - fix generation of heif, pdf, illustrator and svg thumbnails Feb 7, 2023
@szaimen szaimen force-pushed the enh/36543/allow-further-previews branch from 277c467 to 7400e98 Compare February 7, 2023 22:52
@szaimen szaimen added enhancement 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 7, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Feb 7, 2023

/backport to stable25

@szaimen szaimen marked this pull request as ready for review February 7, 2023 22:57
@szaimen szaimen requested review from pulsejet, come-nc, st3iny, a team, ArtificialOwl and blizzz and removed request for a team February 7, 2023 22:57
@szaimen szaimen mentioned this pull request Feb 7, 2023
Closed
@szaimen szaimen force-pushed the enh/36543/allow-further-previews branch from 7400e98 to 4cb0c16 Compare February 7, 2023 23:23
@szaimen szaimen force-pushed the enh/36543/allow-further-previews branch from 4cb0c16 to 112d516 Compare February 7, 2023 23:25
st3iny
st3iny approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@miaulalala miaulalala merged commit 6236235 into master Feb 8, 2023
@miaulalala miaulalala deleted the enh/36543/allow-further-previews branch February 8, 2023 10:18
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 8, 2023
Merged
1 task
@blizzz blizzz mentioned this pull request Feb 9, 2023
Merged
@solracsf solracsf mentioned this pull request Mar 11, 2023
Closed
@solracsf
Copy link
Member

@szaimen any objections backporting to 24?

@szaimen
Copy link
Contributor Author

szaimen commented Mar 15, 2023

We can try

@szaimen
Copy link
Contributor Author

szaimen commented Mar 15, 2023

/backport to stable24

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 15, 2023
Closed
1 task
@enoch85
Copy link
Member

enoch85 commented Sep 26, 2023

@szaimen Does this require OC\\Preview\\PDF in config.php, or is OC\\Preview\\Imaginary enough?

@szaimen
Copy link
Contributor Author

szaimen commented Sep 26, 2023

or is OC\\Preview\\Imaginary enough?

this is enough

@solracsf
Copy link
Member

solracsf commented Sep 26, 2023 •
edited
Loading

@szaimen maybe document somewhere that, once OC\Preview\Imaginary is defined, all these mimetypes are automatically supported and so no need to (re)define them?

@enoch85 enoch85 mentioned this pull request Sep 27, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@st3iny st3iny st3iny approved these changes

@pulsejet pulsejet Awaiting requested review from pulsejet

@come-nc come-nc Awaiting requested review from come-nc

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz blizzz was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug enhancement
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

Setup Imaginary in order to allow it to Rasterise PDF Files for NC Previews
5 participants
@szaimen @solracsf @enoch85 @st3iny @miaulalala