Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(federation): Only request root share info for checking availability #36452

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 31, 2023

Summary

Otherwise this would request a full recursive dirctory listing while the result is never being used

Checklist

@juliusknorr juliusknorr force-pushed the perf/share-availability-check branch from 62c6957 to dedc0dd Compare January 31, 2023 08:01
@juliusknorr juliusknorr added this to the Nextcloud 26 milestone Jan 31, 2023
@juliusknorr juliusknorr marked this pull request as ready for review January 31, 2023 08:04
@juliusknorr juliusknorr force-pushed the perf/share-availability-check branch from dedc0dd to b056fb3 Compare January 31, 2023 08:47
Otherwise this would request a full recursive dirctory listing while the result is never being used

Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr juliusknorr force-pushed the perf/share-availability-check branch from b056fb3 to 7e3ea01 Compare January 31, 2023 10:42
@blizzz blizzz mentioned this pull request Feb 1, 2023
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice catch

probably a leftover from when we switched back to the default scanner instead of the custom one that requested everything

@PVince81 PVince81 merged commit 1fed799 into master Feb 3, 2023
@PVince81 PVince81 deleted the perf/share-availability-check branch February 3, 2023 12:34
@PVince81
Copy link
Member

PVince81 commented Feb 3, 2023

/backport to stable25

@PVince81
Copy link
Member

PVince81 commented Feb 3, 2023

/backport to stable24

1 similar comment
@ChristophWurst
Copy link
Member

/backport to stable24

@ChristophWurst
Copy link
Member

the bot was down for a redeployment

@ChristophWurst
Copy link
Member

/backport to stable25

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable24
git pull origin/stable24

# Create the new backport branch
git checkout -b fix/foo-stable24

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable24

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants