chore: drop depedency php-parser #36393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitormattos
approved these changes
Jan 27, 2023
Failing integration-sharing-v1-video-verification should be fixed by #36389. |
nickvergessen
requested changes
Jan 27, 2023
There was a problem hiding this comment.
Currently brings in Symfony Mailer change. So this is blocked by #30349
|
Thanks, added a Todo to wait for #30349. |
Merged
Just merged |
|
Taking over since kessel is sick |
nickvergessen
force-pushed
the
3rdparty-drop-php-parser
branch
from
2a875e2 to
26b34fe
Compare
Signed-off-by: Daniel Kesselberg <[email protected]>
nickvergessen
force-pushed
the
3rdparty-drop-php-parser
branch
from
26b34fe to
d923565
Compare
|
Repushed to have |
nickvergessen
approved these changes
Feb 2, 2023
nickvergessen
added
3. to review
@kesselb please take care of this. |
kesselb
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dear php-parser,
You were a great help to check that apps are compliant and we did not forget the since and deprecated annotations.
Thank you for all the service you provided us over the years.
TODO
Checklist