Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-framework): Add support for global middlewares #36310

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jan 23, 2023

Resolves: an idea I had in my mind for years

Summary

This allows apps to register middlewares that always register, not just for the app's own requests. Example: ChristophWurst/nextcloud_sentry#329 and a middleware that monitors the performance of other apps' controller methods.

TODO

Checklist

@ChristophWurst ChristophWurst added enhancement 2. developing Work in progress integration pending documentation This pull request needs an associated documentation update labels Jan 23, 2023
@ChristophWurst ChristophWurst added this to the Nextcloud 26 milestone Jan 23, 2023
@ChristophWurst ChristophWurst self-assigned this Jan 23, 2023
@ChristophWurst ChristophWurst changed the title Feat/app framework/global middlewares feat(app-framework): Add support for global middlewares Jan 23, 2023
@ChristophWurst ChristophWurst removed 2. developing Work in progress labels Jan 25, 2023
@ChristophWurst ChristophWurst force-pushed the feat/app-framework/global-middlewares branch from 775c29d to 7b6db59 Compare January 25, 2023 16:44
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews labels Jan 25, 2023
@ChristophWurst ChristophWurst marked this pull request as ready for review January 25, 2023 16:44
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 25, 2023
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 25, 2023
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Jan 26, 2023
@ChristophWurst ChristophWurst force-pushed the feat/app-framework/global-middlewares branch from cb80446 to 9a7e72d Compare January 26, 2023 08:57
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 26, 2023
@ChristophWurst ChristophWurst force-pushed the feat/app-framework/global-middlewares branch from 9a7e72d to 25cb6ba Compare January 26, 2023 08:58
This allows apps to register middlewares that always register, not just
for the app's own requests

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst force-pushed the feat/app-framework/global-middlewares branch from 25cb6ba to 8d9af3e Compare January 26, 2023 10:54
@nickvergessen
Copy link
Member

Should also go into #34692 but can be very short/brief there and link to the docs you already wrote 👏🏼

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Jan 26, 2023

{"reqId":"NeEXNBrFIRtQPBHf8LyF","level":3,"time":"2023-01-26T13:04:48+00:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"require_once(/drone/src/apps/spreed/composer/../vendor/autoload.php): Failed to open stream: No such file or directory at /drone/src/apps/spreed/composer/autoload.php#5","userAgent":"--","version":"26.0.0.3","data":{"app":"PHP"}}

@nickvergessen 👀

nextcloud/spreed#8578?

@ChristophWurst ChristophWurst merged commit ad00a14 into master Jan 26, 2023
@ChristophWurst ChristophWurst deleted the feat/app-framework/global-middlewares branch January 26, 2023 14:17
@nickvergessen
Copy link
Member

#36389

@blizzz blizzz mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement integration
Projects
Development

Successfully merging this pull request may close these issues.

3 participants