-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app-framework): Add support for global middlewares #36310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
enhancement
2. developing
Work in progress
integration
pending documentation
This pull request needs an associated documentation update
labels
Jan 23, 2023
ChristophWurst
changed the title
Feat/app framework/global middlewares
feat(app-framework): Add support for global middlewares
Jan 23, 2023
This was referenced Jan 23, 2023
1 task
ChristophWurst
force-pushed
the
feat/app-framework/global-middlewares
branch
from
January 25, 2023 16:44
775c29d
to
7b6db59
Compare
ChristophWurst
requested review from
come-nc,
nickvergessen,
skjnldsv,
juliusknorr and
ArtificialOwl
January 25, 2023 16:44
skjnldsv
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
Jan 25, 2023
ChristophWurst
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Jan 25, 2023
nickvergessen
approved these changes
Jan 25, 2023
skjnldsv
approved these changes
Jan 26, 2023
ChristophWurst
removed
the
pending documentation
This pull request needs an associated documentation update
label
Jan 26, 2023
ChristophWurst
force-pushed
the
feat/app-framework/global-middlewares
branch
from
January 26, 2023 08:57
cb80446
to
9a7e72d
Compare
ChristophWurst
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Jan 26, 2023
ChristophWurst
force-pushed
the
feat/app-framework/global-middlewares
branch
from
January 26, 2023 08:58
9a7e72d
to
25cb6ba
Compare
This allows apps to register middlewares that always register, not just for the app's own requests Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
feat/app-framework/global-middlewares
branch
from
January 26, 2023 10:54
25cb6ba
to
8d9af3e
Compare
Should also go into #34692 but can be very short/brief there and link to the docs you already wrote 👏🏼 |
{"reqId":"NeEXNBrFIRtQPBHf8LyF","level":3,"time":"2023-01-26T13:04:48+00:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"require_once(/drone/src/apps/spreed/composer/../vendor/autoload.php): Failed to open stream: No such file or directory at /drone/src/apps/spreed/composer/autoload.php#5","userAgent":"--","version":"26.0.0.3","data":{"app":"PHP"}} |
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: an idea I had in my mind for years
Summary
This allows apps to register middlewares that always register, not just for the app's own requests. Example: ChristophWurst/nextcloud_sentry#329 and a middleware that monitors the performance of other apps' controller methods.
TODO
Checklist
required