Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple session start calls #36239

Closed
wants to merge 5 commits into from

Conversation

the-djmaze
Copy link

OC\Session\Internal->clear() reopens the session several times as regenerateId() also reopens the sessions.
So it was like:

  • $this->reopen();
  • $this->regenerateId(); // $this->reopen();
  • $this->startSession(true);

Secondly the sessionClosed wasn't handled properly as read_and_close might or might not be used.

@szaimen szaimen requested review from juliusknorr, ChristophWurst, a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team January 19, 2023 09:18
@szaimen szaimen added this to the Nextcloud 26 milestone Jan 19, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label Jan 19, 2023
@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
This was referenced May 3, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@sorbaugh
Copy link
Contributor

sorbaugh commented Aug 16, 2024

Hello @the-djmaze ! We're closing this PR as it seems that the original issue was solved with a different approach :)
Nevertheless, thank you so much for the time you put into this! Looking forward to any additional contributions!

@the-djmaze the-djmaze deleted the session_start branch August 19, 2024 13:17
@the-djmaze
Copy link
Author

Good that it is solved 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress stale Ticket or PR with no recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: On Log out I always get: "... ignoring session_start() because a session is already active ..."
5 participants