Fix 32bit support and add workflow for 32bits testing

[come-nc]

Signed-off-by: Côme Chilliet [email protected]

• Resolves: Bring back 32 bit support on Nextcloud 26 #36072

Summary

Add 32bits to CI and fix errors

TODO

• Have a working 32bits PHPUnit CI step
• Refine which tests it runs or not
• Fix errors
• Refine when this CI step runs or not
• Backport CI step (and fixes if needed) to stable25

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[come-nc]

There were 2 failures:

1) Test\User\UserTest::testSetQuota
Expectation failed for method name is "setUserValue" when invoked 1 time(s)
Parameter 3 for invocation OCP\IConfig::setUserValue('foo', 'files', 'quota', '0 B', null) does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'23 TB'
+'0 B'

/__w/server/server/lib/private/User/User.php:526
/__w/server/server/tests/lib/User/UserTest.php:744

2) Test\User\UserTest::testSetQuotaAddressNoChange
OCP\IConfig::setUserValue('foo', 'files', 'quota', '0 B', null) was not expected to be called.

/__w/server/server/lib/private/User/User.php:526
/__w/server/server/tests/lib/User/UserTest.php:831

So it works.

But either we do not have enough tests on quota or they are not run by the selection I’ve put, because I expected type errors as well on file sizes.
We need to add tests specifically for files over 4GB I guess.

There is also a whole bunch of:

1) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "all" (array(0, 1, 2, 3), array(), array())
ValueError: Epoch doesn't fit in a PHP integer

/__w/server/server/apps/dav/lib/CalDAV/CalDavBackend.php:2738
/__w/server/server/apps/dav/lib/CalDAV/CalDavBackend.php:1209
/__w/server/server/apps/dav/tests/unit/CalDAV/AbstractCalDavBackend.php:221
/__w/server/server/apps/dav/tests/unit/CalDAV/CalDavBackendTest.php:426

[come-nc]

For the ValueError: Epoch doesn't fit in a PHP integer errors from dav tests, they are triggered by calling getTimestamp on DateTime objects for dates after 2038.
We need to decide whether we want to support events after 2038 in dav/calendar or not for 32bits, which would imply retyping all timestamps in there to int|float. Other solution is to document it as known limitation on 32bits and skip those tests on 32bits.
ping @PVince81 @AndyScherzinger

[AndyScherzinger]

support events after 2038

I'd be fine to document it as a known limitation, that 32-bit can't handle dates past that time.

[come-nc]

• Document that events past 2038 (check actual limit) are not supported on 32bit

[ChristophWurst]

review was wrongly requested because the PR was set for review already. put it back to draft.

[DaphneMuller]

hello @come-nc
Thank you so much for your work on this pull request! This ticket seems to have the tag 'pending documentation'.
Is there any chance you could clarify what documentation is missing? Is this for admins or for app developers?

[MichaIng]

@come-nc
Why was this never backported to NC25? It is high likely what fixes quotas on NC26 while it is still broken on NC25. It is is overall to much/large, we could also cherry-pick some commits?

[come-nc]

@come-nc Why was this never backported to NC25? It is high likely what fixes quotas on NC26 while it is still broken on NC25. It is is overall to much/large, we could also cherry-pick some commits?

Several reasons, mainly this was fixed through strong typing using union type int|float which is only available on PHP 8.0 and higher, and thus cannot be used on 25.
So backporting would have meant doing it again using phpdoc instead of real typing.

Also you can see I had to change things in lib/public (OCP), which we tend to avoid on bugfix releases.

[MichaIng]

Okay, makes sense. Then it will be some detectives work to find the part which fixes quota usage on Nextcloud 25. Or the monkeys task to translate all union types to phpdoc comments for backporting everything 😄. I'll see if I can do that, excluding CI and unrelated stuff.

Also you can see I had to change things in lib/public (OCP), which we tend to avoid on bugfix releases.

In this cases it fixes bugs, so I think it is necessary. But I also think most of these are in NC25 already (phpdoc) via #35734 and some other PRs.

[MichaIng]

PR up which backports most of the changes done here: #37877