-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend reference API for (future) frontend picker #35557
Extend reference API for (future) frontend picker #35557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Oh I forgot to mention: in the |
lib/public/Collaboration/Reference/IDiscoverableReferenceProvider.php
Outdated
Show resolved
Hide resolved
b128634
to
d1eb33b
Compare
d1eb33b
to
7ef7268
Compare
@juliushaertl Where can we listen to In other words, in server, where can we call (and where does it makes sense to call) I've seen similar-ish stuff in |
Same feeling that there could be a better place but I also added one to base.php in the first PR: Line 927 in 052dcde
So maybe we just stick with that for now. |
Thanks, gotta problem though. Just added 311527e I don't know why but I can't inject
But I don't get why I also tried injecting
Any idea? |
However you can inject the
|
311527e
to
e0f51b3
Compare
@juliushaertl Thanks. Done, works. I thought I didn't try to inject |
At least there is no replacement yet for core parts that need to inject initial state. And the new interface just wraps the deprecated, so while apps should use the new one, the deprecated one should still be fine within the affected core code base. |
f80bb98
to
c3b8e1c
Compare
783e49c
to
13ab5cc
Compare
I don't get the remaining psalm check failure:
It's fine for server/lib/private/Collaboration/Reference/File/FileReferenceEventListener.php Lines 42 to 44 in 4d04030
|
13ab5cc
to
ce43b6f
Compare
e6c2573
to
34893d7
Compare
34893d7
to
abb9a46
Compare
d6cc645
to
39ac533
Compare
@juliushaertl This is ready for review IMO. Nothing more to add for now. Some recent additions to this PR:
|
Pushed a fix for the psalm error |
3b2fe91
to
ea66a7f
Compare
ea66a7f
to
15e0608
Compare
@marcelklehr @juliushaertl Thanks for the review. |
15e0608
to
cf39328
Compare
Rebased and squashed the fixup commits and updated the autoloader. |
28f2363
to
fbc249e
Compare
4eab4b5
to
ff79b40
Compare
- add 2 interfaces for discoverable and searchable reference providers - new OCS route to get info on discoverable/searchable reference providers - new abstract ADiscoverableReferenceProvider that only implements jsonSerialize - listen to RenderReferenceEvent to inject provider list with initial state Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
ff79b40
to
81c2122
Compare
Please document in #34692 |
hello @julien-nc |
Hello! Are you familiar with our documentation process already? Changes that affect administrators should be documented here: While I understand sometimes it's handy to merge fast to get your changes in, it would be great if next time you could try to add the documentation before merging. You can find more information on that here: If all your documentation efforts are done, please remove the label 'pending documentation' and check the checkbox in your opening note and I'll stop bugging you :) Many thanks in advance and thanks again for your work! |
refs #31667
We forgot something in the specs: the fontend only knows the list of registered widgets to render references. We need more information for the available providers (title, icon etc...) to feed the reference picker. I can think of 2 ways to go:
vue-richtext
I went with the API endpoint. (Or did I miss something obvious?)
So, a reference provider can support multiple search providers. Thinking out loud: We need to be careful to properly render heterogeneous search results in the frontend.