Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump swiftmailer/swiftmailer to 6.3.0 in stable25 #35174

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Bump swiftmailer/swiftmailer to 6.3.0 in stable25 #35174

merged 2 commits into from
Nov 22, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 15, 2022 •
edited
Loading

@come-nc come-nc self-assigned this Nov 15, 2022
@come-nc come-nc changed the base branch from master to stable25 November 15, 2022 10:35
@come-nc come-nc added the 3. to review Waiting for reviews label Nov 15, 2022
@come-nc come-nc added this to the Nextcloud 25.0.2 milestone Nov 15, 2022
@come-nc come-nc force-pushed the fix/bump-swiftmailer/swiftmailer-to-6.3.0-in-stable25 branch from 6af8997 to 76272f5 Compare November 15, 2022 10:35
szaimen
szaimen approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@come-nc come-nc requested review from a team, icewind1991, blizzz and skjnldsv and removed request for a team November 15, 2022 15:35
@blizzz blizzz mentioned this pull request Nov 21, 2022
Merged
1 task
@come-nc come-nc marked this pull request as ready for review November 22, 2022 07:53
blizzz
blizzz requested changes Nov 22, 2022
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty?

@come-nc
Align 3rdparty with stable25
345a216 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc force-pushed the fix/bump-swiftmailer/swiftmailer-to-6.3.0-in-stable25 branch from 291a826 to 345a216 Compare November 22, 2022 08:54
@come-nc
Copy link
Contributor Author

come-nc commented Nov 22, 2022

empty?

I checkout but forgot to pull in 3rdparty, thanks a lot for spotting that!
Fixed the same mistake in stable24 PR as well.

@come-nc come-nc requested a review from blizzz November 22, 2022 08:55
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 22, 2022
@come-nc come-nc merged commit 8aa6c10 into stable25 Nov 22, 2022
@come-nc come-nc deleted the fix/bump-swiftmailer/swiftmailer-to-6.3.0-in-stable25 branch November 22, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@blizzz blizzz blizzz approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@come-nc come-nc

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 25.0.2
Development

Successfully merging this pull request may close these issues.

[Bug]: Support PHP8.1 with swiftmailer
3 participants
@come-nc @blizzz @szaimen