-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed mapping to font #34419
Changed mapping to font #34419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request.
This should also get adjusted in core/js/mimetypelist.js
In addition it might make sense for other font related mime types as well
@jancborchardt Maybe you can come up with a nice icon for font files? |
Yes, |
* Updated mimetypelist icon mapping Signed-off-by: Dany1718 <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
I rebased the PR and pushed a commit providing the icon @jancborchardt suggested, it looks like this now: |
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Fix: #39705 |
Previous code had "application/font-woff": "image"
which caused the error.
New code has fixed the mapping.