Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable22] always use the default fs owner when storing versions #33975

Closed
wants to merge 1 commit into from

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Sep 8, 2022

  • ⚠️ This backport had conflicts and is incomplete

backport of #33804

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 22.2.11 milestone Sep 8, 2022

$files_view = new View('/'.$uid .'/files');
/** @var IRootFolder $rootFolder */
$rootFolder = \OC::$server->get(IRootFolder::class);

Check failure

Code scanning / Psalm

UndefinedDocblockClass

Docblock-defined class, interface or enum named OCA\Files_Versions\IRootFolder does not exist

$files_view = new View('/'.$uid .'/files');
/** @var IRootFolder $rootFolder */
$rootFolder = \OC::$server->get(IRootFolder::class);

Check failure

Code scanning / Psalm

UndefinedClass

Class, interface or enum named OCA\Files_Versions\IRootFolder does not exist
$files_view = new View('/'.$uid .'/files');
/** @var IRootFolder $rootFolder */
$rootFolder = \OC::$server->get(IRootFolder::class);
$userFolder = $rootFolder->getUserFolder($uid);

Check failure

Code scanning / Psalm

UndefinedDocblockClass

Docblock-defined class, interface or enum named OCA\Files_Versions\IRootFolder does not exist
@@ -189,7 +194,13 @@
}

// no use making versions for empty files
if ($fileInfo->getSize() === 0) {
if ($file->getSize() === 0) {

Check failure

Code scanning / Psalm

UndefinedVariable

Cannot find referenced variable $file
return false;
}

$event = new CreateVersionEvent($file);

Check failure

Code scanning / Psalm

UndefinedVariable

Cannot find referenced variable $file
}

$event = new CreateVersionEvent($file);
$eventDispatcher->dispatch('OCA\Files_Versions::createVersion', $event);

Check failure

Code scanning / Psalm

TooManyArguments

Too many arguments for method Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch - saw 2
}

$event = new CreateVersionEvent($file);
$eventDispatcher->dispatch('OCA\Files_Versions::createVersion', $event);

Check failure

Code scanning / Psalm

InvalidArgument

Argument 1 of Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch expects object, "OCA\\Files_Versions::createVersion" provided
@blizzz
Copy link
Member

blizzz commented Oct 6, 2022

@icewind1991 conflicts

@blizzz
Copy link
Member

blizzz commented Nov 3, 2022

still

@blizzz
Copy link
Member

blizzz commented Dec 8, 2022

closing

@blizzz blizzz closed this Dec 8, 2022
@skjnldsv skjnldsv deleted the backport/33804/stable22 branch March 14, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants