-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable22] always use the default fs owner when storing versions #33975
Conversation
Signed-off-by: Robin Appelman <[email protected]>
|
||
$files_view = new View('/'.$uid .'/files'); | ||
/** @var IRootFolder $rootFolder */ | ||
$rootFolder = \OC::$server->get(IRootFolder::class); |
Check failure
Code scanning / Psalm
UndefinedDocblockClass
|
||
$files_view = new View('/'.$uid .'/files'); | ||
/** @var IRootFolder $rootFolder */ | ||
$rootFolder = \OC::$server->get(IRootFolder::class); |
Check failure
Code scanning / Psalm
UndefinedClass
$files_view = new View('/'.$uid .'/files'); | ||
/** @var IRootFolder $rootFolder */ | ||
$rootFolder = \OC::$server->get(IRootFolder::class); | ||
$userFolder = $rootFolder->getUserFolder($uid); |
Check failure
Code scanning / Psalm
UndefinedDocblockClass
@@ -189,7 +194,13 @@ | |||
} | |||
|
|||
// no use making versions for empty files | |||
if ($fileInfo->getSize() === 0) { | |||
if ($file->getSize() === 0) { |
Check failure
Code scanning / Psalm
UndefinedVariable
return false; | ||
} | ||
|
||
$event = new CreateVersionEvent($file); |
Check failure
Code scanning / Psalm
UndefinedVariable
} | ||
|
||
$event = new CreateVersionEvent($file); | ||
$eventDispatcher->dispatch('OCA\Files_Versions::createVersion', $event); |
Check failure
Code scanning / Psalm
TooManyArguments
} | ||
|
||
$event = new CreateVersionEvent($file); | ||
$eventDispatcher->dispatch('OCA\Files_Versions::createVersion', $event); |
Check failure
Code scanning / Psalm
InvalidArgument
@icewind1991 conflicts |
still |
closing |
backport of #33804