-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use LazyUser in DefaultShareProvider #33581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
PVince81,
ArtificialOwl and
come-nc
and removed request for
a team
August 17, 2022 12:30
PVince81
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
artonge
reviewed
Aug 17, 2022
Merged
CarlSchwan
approved these changes
Aug 18, 2022
DB unit tests are failing |
@icewind1991 please fix the tests |
Merged
PVince81
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
Sep 16, 2022
Merged
Merged
@icewind1991 can you please fix the tests? |
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Signed-off-by: Robin Appelman <[email protected]>
Rebased and fixed conflicts |
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
approved these changes
Jun 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robin Appelman [email protected]