Unify initial and updated quota display #33495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial quota display uses the total available space rather than the quota. Moreover, the relative usage is based on the total space rather than the quota. Due to this now the total available space is also used when updating the quota display. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The tooltip of the initial quota display showed the usage percenteage and the total available space. However, the total available space was redundant, as it was shown just below. The tooltip of the updated quota display showed the usage percenteage, but based on the quota rather than the total available space, so there was a mismatch between the tooltip and the bar below. Now the tooltip of the initial and the updated quota display both show just the usage percenteage based on the total available space. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
|
/backport to stable24 |
Pytal
approved these changes
Aug 11, 2022
Merged
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the initial quota display, the updated quota display used the quota rather than the total available space. Due to this there was a "jump" in the quota when the display was updated if the quota is larger than the total available space. The relative usage is based on the total available space, so the updated quota display was changed to also use the total available space.
The tooltip was also inconsistent between the initial quota display and the updated quota display. It was unified to use only the relative usage percenteage, as showing again the total available space in the tooltip was redundant, and to round the value to make it consistent also with the quota display in the personal information page. Unfortunately this change requires new translation strings, but they just show a percenteage symbol after a number, so even if untranslated they should be fine in a lot of languages.
How to test
Expected result
The updated quota display still shows the total available space. The tooltip with the usage percenteage matches the usage bar below.
Actual result
The updated quota display now shows the quota rather than the total available space. The tooltip with the usage percenteage matches the proportion between the used space and the quota, although it is different from the usage bar below.