Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #33415

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Fix integration tests #33415

merged 1 commit into from
Aug 8, 2022

Conversation

CarlSchwan
Copy link
Member

The HTML tags changed in the notification apps, and adapt selector to the
new state

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Aug 1, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Aug 1, 2022
@CarlSchwan CarlSchwan self-assigned this Aug 1, 2022
@CarlSchwan CarlSchwan added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 1, 2022
The html tags changed in the notification apps, adapt selector to the
new state

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan force-pushed the fix/integration-test-notif branch from 11197f8 to a24ed79 Compare August 1, 2022 10:38
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good (based on nextcloud/notifications#1236) and acceptance tests pass 👍

@CarlSchwan CarlSchwan added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 4, 2022
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 8, 2022
@CarlSchwan CarlSchwan merged commit d95557e into master Aug 8, 2022
@CarlSchwan CarlSchwan deleted the fix/integration-test-notif branch August 8, 2022 15:06
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants