Fix accessibility of buttons in the external storage configuration #33357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tyrylu thanks a lot for your accessibility fix. can you please rebase / rearrange your commits ? a single commit should be enough for this fix let us know if you need help. |
|
/rebase |
nextcloud-command
force-pushed
the
external_storage_buttons_a11y
branch
from
8fde5b8 to
7f82051
Compare
Pytal
reviewed
Jul 27, 2022
|
Added a fixup to use the
|
Pytal
force-pushed
the
external_storage_buttons_a11y
branch
from
3e64cb2 to
b6eb687
Compare
Note that there is no keyboard only way to close the dropdown Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
external_storage_buttons_a11y
branch
from
b6eb687 to
d760cde
Compare
Pytal
approved these changes
Aug 5, 2022
Pytal
requested review from
a team,
PVince81 and
skjnldsv
and removed request for
a team
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means adding the button role and a tabindex attribute. It also tries to handle the expanded state for the advanced options dropdown.
Note, however, that there is no keyboard only way how to close the dropdown.