Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify the login page explicitly by the page title #33281

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Identify the login page explicitly by the page title #33281

merged 1 commit into from
Jul 21, 2022
+9 −2

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jul 19, 2022

By default the page title would be "Login - Nextcloud"

@Pytal Pytal added 3. to review Waiting for reviews accessibility labels Jul 19, 2022
@Pytal Pytal added this to the Nextcloud 25 milestone Jul 19, 2022
@Pytal Pytal self-assigned this Jul 19, 2022
@Pytal Pytal force-pushed the enh/a11y-login-page-title branch from 96a9db5 to 7d66246 Compare July 19, 2022 17:23
szaimen
szaimen reviewed Jul 19, 2022
View reviewed changes
@Pytal
Copy link
Member Author

Pytal commented Jul 20, 2022 •
edited
Loading

Going with "Login – Nextcloud"

szaimen
szaimen reviewed Jul 20, 2022
View reviewed changes
@Pytal Pytal force-pushed the enh/a11y-login-page-title branch from 7d66246 to cfc24f5 Compare July 20, 2022 18:09
szaimen
szaimen approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but did not test

@github-actions
Copy link
Contributor

Possible performance regression detected

Show Output 
2 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
≠ /remote.php/dav/files/test/many_files with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

@CarlSchwan
Copy link
Member

I feel like this shoukd be done in the backend instead by just passinf a title to the template arguments

@CarlSchwan
Copy link
Member

That reminds me i need to revisit #29881

@nickvergessen
Copy link
Member

I feel like this shoukd be done in the backend instead by just passinf a title to the template arguments

The guests template does not support this yet:
https://github.com/nextcloud/server/blob/master/core/templates/layout.guest.php#L10

but yeah something like
https://github.com/nextcloud/server/blob/master/core/templates/layout.user.php#L19-L24

@Pytal
Identify the login page explicitly by the page title

Verified

This commit was signed with the committer’s verified signature.
aroralanuk Kunal Arora
GPG key ID: 0BA6B0ECFE790BB1
Verified
Learn about vigilant mode
92500e8 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal force-pushed the enh/a11y-login-page-title branch from cfc24f5 to 92500e8 Compare July 20, 2022 23:56
@Pytal
Copy link
Member Author

Pytal commented Jul 20, 2022

@CarlSchwan @nickvergessen what do you think now?

@PVince81 PVince81 merged commit 58a2989 into master Jul 21, 2022
@PVince81 PVince81 deleted the enh/a11y-login-page-title branch July 21, 2022 12:12
@blizzz
Copy link
Member

blizzz commented Jul 22, 2022

@PVince81 CI was positively failing

@blizzz blizzz mentioned this pull request Jul 22, 2022
Merged
@nickvergessen nickvergessen mentioned this pull request Jul 26, 2022
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishavijay nimishavijay

@nickvergessen nickvergessen

@CarlSchwan CarlSchwan

@szaimen szaimen

@PVince81 PVince81

@raimund-schluessler raimund-schluessler

@julien-nc julien-nc

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Pytal @CarlSchwan @nickvergessen @blizzz @szaimen @nimishavijay @PVince81