Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hover css variable for primary buttons #33267

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 18, 2022

This should fix some buttons becoming to bright on hover/focus when using the server styles and add a missing focus border.

Couldn't find a button quickly but setting one of the firstrunwizard buttons to primary for comparison (on focus):

Before:
Screenshot 2022-07-18 at 18 26 16

After:
Screenshot 2022-07-18 at 18 25 14

@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 18, 2022

@jancborchardt @marcoambrosini What would be a proper focus feedback for a primary button on white background? We mostly use a 2px border now on other elements, but for that button it is not really visible from my perspective.

Edit: Nevermind just found that the button component uses the main text color then.

@juliusknorr juliusknorr force-pushed the bugfix/noid/button-hover branch from 4440235 to 9e0d6f5 Compare July 18, 2022 16:24
@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Jul 18, 2022
@juliusknorr juliusknorr requested review from a team, PVince81, Pytal, szaimen and jancborchardt and removed request for a team July 18, 2022 16:27
@juliusknorr juliusknorr merged commit 9e3c8b6 into master Jul 19, 2022
@juliusknorr juliusknorr deleted the bugfix/noid/button-hover branch July 19, 2022 06:14
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants