Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use material design icons in Email component #33242

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jul 16, 2022

Drop some legacy class based icons

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but did not test

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but did not test

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 18, 2022
@Pytal

This comment was marked as outdated.

1 similar comment
@Pytal

This comment was marked as outdated.

@nextcloud-command nextcloud-command force-pushed the enh/email-material-icons branch from 55ee119 to 2a0a850 Compare July 18, 2022 23:04
@Pytal
Copy link
Member Author

Pytal commented Jul 19, 2022

/compile amend /

@nextcloud-command nextcloud-command force-pushed the enh/email-material-icons branch 2 times, most recently from 6b322f2 to b452d1d Compare July 19, 2022 02:27
@nickvergessen
Copy link
Member

Conflicting files
dist/core-common.js
dist/core-common.js.map

@Pytal
Copy link
Member Author

Pytal commented Jul 20, 2022

/compile amend /

@nextcloud-command nextcloud-command force-pushed the enh/email-material-icons branch from b452d1d to 3d8a7af Compare July 20, 2022 18:09
@nickvergessen
Copy link
Member

Compile is not the issue, you need to rebase

Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@Pytal Pytal force-pushed the enh/email-material-icons branch from 3d8a7af to ecdde8d Compare July 21, 2022 00:05
@Pytal Pytal merged commit ea73f66 into master Jul 21, 2022
@Pytal Pytal deleted the enh/email-material-icons branch July 21, 2022 01:04
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: emails feature: settings technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants