Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump underscore from 1.12.0 to 1.13.4 #32733

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 6, 2022

Bumps underscore from 1.12.0 to 1.13.4.

Commits
  • a15d1af Update generated files, tag 1.13.4 release
  • 979dfc4 Merge branch 'prepare-1.13.4'
  • fcb149d Add a change log entry for 1.13.4
  • cf6ed6f Bump the version to 1.13.4
  • 75d257f Merge pull request #2959 from petschki/module-federation-version
  • 46d77d3 Fix for webpack module federation "No version" error
  • da06656 Merge pull request #2956 from zackschuster/patch-1
  • adf8838 fix heading nesting
  • 5af5ecb update contributing to clarify how to clone from other sources
  • 6ce24a2 add fsck error workaround to contributing.md #2887
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team June 6, 2022 16:06
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 6, 2022

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@Pytal
Copy link
Member

Pytal commented Jun 6, 2022

/compile amend /

@nextcloud-command nextcloud-command force-pushed the dependabot/npm_and_yarn/underscore-1.13.4 branch from 5f2b6bc to e8dde7a Compare June 6, 2022 16:21
@PVince81
Copy link
Member

@dependabot-bot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/underscore-1.13.4 branch from e8dde7a to dc8d66f Compare July 26, 2022 12:29
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@PVince81 PVince81 self-assigned this Jul 26, 2022
@PVince81
Copy link
Member

/compile amend /

Bumps [underscore](https://github.com/jashkenas/underscore) from 1.12.0 to 1.13.4.
- [Release notes](https://github.com/jashkenas/underscore/releases)
- [Commits](jashkenas/underscore@1.12.0...1.13.4)

---
updated-dependencies:
- dependency-name: underscore
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the dependabot/npm_and_yarn/underscore-1.13.4 branch from dc8d66f to 7566b30 Compare July 26, 2022 13:10
@PVince81
Copy link
Member

JS test failures all are related to the Snapper library

@PVince81
Copy link
Member

likely related to _.debounce() which usually would be bypassed by simulating the clock ticking forward.
not sure why this stopped working after the update

@PVince81
Copy link
Member

probably lodash/lodash#2893 ...

@PVince81 PVince81 merged commit bbe99e6 into master Jul 26, 2022
@PVince81 PVince81 deleted the dependabot/npm_and_yarn/underscore-1.13.4 branch July 26, 2022 16:05
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants