Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getLocale and getLanguage from @nc-l10n #32257

Closed
wants to merge 1 commit into from
Closed

Use getLocale and getLanguage from @nc-l10n #32257

wants to merge 1 commit into from

Conversation

artonge
Copy link
Contributor

@artonge artonge commented May 3, 2022 •
edited
Loading

This PR make sure that the logic is not duplicated.

To merge when nextcloud-libraries/nextcloud-l10n#434 is released

⚠️ Let's wait until @nextcloud/dialogs and @nextcloud/moment update @nextcloud/l10n to reduce the amount of warnings.

@artonge artonge added this to the Nextcloud 25 milestone May 3, 2022
@artonge artonge self-assigned this May 3, 2022
@artonge artonge mentioned this pull request May 3, 2022
Merged
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label May 4, 2022
@artonge artonge force-pushed the feat/use_nc_l10n branch from 098df9b to 207d71c Compare May 4, 2022 09:25
tcitworld
tcitworld reviewed May 5, 2022
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting to add some context to the message

core/src/OC/l10n.js Outdated Show resolved Hide resolved
core/src/OC/l10n.js Outdated Show resolved Hide resolved
@artonge artonge force-pushed the feat/use_nc_l10n branch from 207d71c to b35fc69 Compare May 5, 2022 12:19
@artonge artonge changed the title Use getLocale and getLanguage from nc-l10n Use getLocale and getLanguage from @nc-l10n May 5, 2022
@artonge artonge requested review from a team, PVince81, Pytal and szaimen and removed request for a team May 10, 2022 16:29
@artonge artonge force-pushed the feat/use_nc_l10n branch from b35fc69 to d5f9852 Compare May 10, 2022 16:31
@artonge artonge removed request for PVince81, Pytal and szaimen May 10, 2022 16:47
@artonge artonge added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 10, 2022
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@artonge artonge closed this Sep 28, 2023
@skjnldsv skjnldsv deleted the feat/use_nc_l10n branch March 14, 2024 07:45
@skjnldsv skjnldsv removed this from the Nextcloud 28 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcitworld tcitworld tcitworld left review comments

Assignees

@artonge artonge

Labels
2. developing Work in progress dependencies pending documentation This pull request needs an associated documentation update technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@artonge @tcitworld @ChristophWurst @blizzz @skjnldsv