Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] Fix incorrect if conditions in View #31878

Merged
merged 1 commit into from
Apr 14, 2022
Merged

[stable23] Fix incorrect if conditions in View #31878

merged 1 commit into from
Apr 14, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Apr 7, 2022

Backport #31754

Only backported the fix itself as the other commit did not apply

@come-nc come-nc added the 3. to review Waiting for reviews label Apr 7, 2022
@come-nc come-nc added this to the Nextcloud 23.0.4 milestone Apr 7, 2022
@come-nc come-nc self-assigned this Apr 7, 2022
@come-nc come-nc requested review from a team, icewind1991, blizzz and juliusknorr and removed request for a team April 7, 2022 13:39
@come-nc
Copy link
Contributor Author

come-nc commented Apr 7, 2022

/backport to stable22

@come-nc come-nc requested a review from artonge April 7, 2022 13:42
@blizzz
Copy link
Member

blizzz commented Apr 13, 2022

/rebase

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 13, 2022
@blizzz blizzz mentioned this pull request Apr 13, 2022
Merged
@come-nc @artonge
Fix incorrect if conditions in View
aef9ba2 
($something->getPermissions() && Constants::PERMISSION_READ) does not
  make sense as PERMISSION_READ contant is 1 this will always evaluate to
  true.
getPersmissions is returning an int which is a bitwise combination as
  documented in the interface, so it should be used with bit operators.

Signed-off-by: Côme Chilliet <[email protected]>
@artonge artonge force-pushed the backport/31754/stable23 branch from 487e06b to aef9ba2 Compare April 14, 2022 09:06
@blizzz blizzz merged commit bc52905 into stable23 Apr 14, 2022
@blizzz blizzz deleted the backport/31754/stable23 branch April 14, 2022 11:42
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@blizzz blizzz blizzz approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@come-nc come-nc

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 23.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@come-nc @blizzz @artonge