Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fit newFileMenu to css guidelines #3118

Merged
merged 4 commits into from
Jan 23, 2017
Merged

Fit newFileMenu to css guidelines #3118

merged 4 commits into from
Jan 23, 2017

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 17, 2017 •
edited
Loading

Following #3114

Two bugs to fix:

  • Why is the label link to the input not working?
  • Why is the new Folder button not working?

@nextcloud/designers please review

@skjnldsv skjnldsv added 2. developing Work in progress design Design, UI, UX, etc. feature: files help wanted labels Jan 17, 2017
@mention-bot
Copy link

@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @MorrisJobke and @butonic to be potential reviewers.

@skjnldsv skjnldsv added this to the Nextcloud 12.0 milestone Jan 17, 2017
@skjnldsv skjnldsv force-pushed the newFileMenu-css-guidelines branch from 6829b2b to 606f0c7 Compare January 21, 2017 19:06
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 21, 2017 •
edited
Loading

Before/After
capture d ecran_2017-01-21_20-10-32 capture d ecran_2017-01-21_20-10-05

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress help wanted labels Jan 21, 2017
@skjnldsv skjnldsv self-assigned this Jan 21, 2017
@codecov-io
Copy link

codecov-io commented Jan 21, 2017 •
edited
Loading

Current coverage is 53.93% (diff: 100%)

Merging #3118 into master will decrease coverage by <.01%

@@             master      #3118   diff @@
==========================================
  Files          1299       1299          
  Lines         80145      80145          
  Methods        7909       7909          
  Messages          0          0          
  Branches       1248       1248          
==========================================
- Hits          43228      43227     -1   
- Misses        36917      36918     +1   
  Partials          0          0

Powered by Codecov. Last update 0d6e3ca...0fc0bcf

MorrisJobke
MorrisJobke previously requested changes Jan 21, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the input field for new file/folder is not hovered anymore it will hide:

bildschirmfoto 2017-01-21 um 17 17 01

@skjnldsv skjnldsv dismissed MorrisJobke’s stale review January 22, 2017 15:06

Works fine with #3187. :)

@skjnldsv skjnldsv requested a review from MorrisJobke January 22, 2017 15:06
@MorrisJobke
Copy link
Member

Works fine with #3187. :)

It's still there. Let's wait for #3187 to be in and then we can continue this one here.

@skjnldsv @MorrisJobke
fit newFileMenu to css guidelines
418ebfb 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv @MorrisJobke
Popover positionning and classes
961fcfa 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv @MorrisJobke
Popover positionning fix
3d86275 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv @MorrisJobke
Popover newFolder input fix
0fc0bcf 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@MorrisJobke MorrisJobke force-pushed the newFileMenu-css-guidelines branch from 50d2546 to 0fc0bcf Compare January 22, 2017 17:45
@MorrisJobke
Copy link
Member

I rebased this because #3187 was merged.

@skjnldsv
Copy link
Member Author

No conflicts? Lucky you! 😉

@MorrisJobke
Copy link
Member

As said: the weird hidden on hover is still there 😢

@skjnldsv
Copy link
Member Author

😕
kazam_screencast_00001

MorrisJobke
MorrisJobke approved these changes Jan 22, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now fine 👍 (I guess some caching issues before, but I really refreshed hard multiple times)

@LukasReschke LukasReschke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 22, 2017
@MorrisJobke MorrisJobke merged commit 16afaa7 into master Jan 23, 2017
@MorrisJobke MorrisJobke deleted the newFileMenu-css-guidelines branch January 23, 2017 02:39
@ChristophWurst
Copy link
Member

Before/After
capture d ecran_2017-01-21_20-10-32 capture d ecran_2017-01-21_20-10-05

The top left corner is not rounded. @skjnldsv could you please fix that? :-)
Also the menu seems to be broken in Gallery (now)

@skjnldsv
Copy link
Member Author

@ChristophWurst I saw that for the gallery. Needed to be fixed in the gallery app. On it! :)

This was referenced Jan 26, 2017
Closed
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasReschke LukasReschke LukasReschke approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@schiessle schiessle Awaiting requested review from schiessle

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. feature: files feature: scss
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@skjnldsv @mention-bot @codecov-io @MorrisJobke @ChristophWurst @LukasReschke