Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background job time windows #30945

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Background job time windows #30945

merged 3 commits into from
Feb 8, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 31, 2022 •
edited
Loading

  • Should be used by background jobs which are rather heavy but are not time critical:
    • Background jobs in server code
    • Activity expiration
    • Suspicious login
    • Mail ?
    • Talk ?
  • Write documentation for app developers
  • Write documentation for sysadmins

@nickvergessen nickvergessen added 2. developing Work in progress technical debt pending documentation This pull request needs an associated documentation update performance 🚀 labels Jan 31, 2022
@nickvergessen nickvergessen added this to the Nextcloud 24 milestone Jan 31, 2022
@PVince81 PVince81 mentioned this pull request Feb 7, 2022
Closed
@PVince81
Copy link
Member

PVince81 commented Feb 7, 2022

@nickvergessen I've assigned you since you worked on this, let me know if you're not able to finish it and I can find someone else, let me know

it looks like the base work is already done, the decision/discussion for switching individual background jobs to the new mode could be done separately if needed

@nickvergessen
Copy link
Member Author

I've assigned you since you worked on this, let me know if you're not able to finish it and I can find someone else, let me know

it looks like the base work is already done, the decision/discussion for switching individual background jobs to the new mode could be done separately if needed

Yes, it's basically done, just missing the developer documentation and a note in the upgrade guideline for admins

@nickvergessen nickvergessen marked this pull request as ready for review February 7, 2022 12:53
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 7, 2022
@nickvergessen nickvergessen force-pushed the techdebt/noid/background-job-time-windows branch from b4c40ef to b8e0a3d Compare February 7, 2022 12:55
@nickvergessen
Copy link
Member Author

Rebased and squashed

@nickvergessen nickvergessen requested review from a team, PVince81, blizzz, skjnldsv, juliusknorr, icewind1991 and CarlSchwan and removed request for a team February 7, 2022 12:55
ChristophWurst
ChristophWurst approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean :shipit:

@ChristophWurst ChristophWurst mentioned this pull request Feb 7, 2022
Closed
6 tasks
miaulalala
miaulalala approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 7, 2022
@nickvergessen nickvergessen mentioned this pull request Feb 7, 2022
Closed
9 tasks
@tcitworld tcitworld mentioned this pull request Feb 7, 2022
Merged
@szaimen
Copy link
Contributor

szaimen commented Feb 8, 2022

Merge?

@nickvergessen nickvergessen merged commit c58f8d6 into master Feb 8, 2022
@nickvergessen nickvergessen deleted the techdebt/noid/background-job-time-windows branch February 8, 2022 13:46
This was referenced Feb 10, 2022
Merged
Open
@AndyScherzinger
Copy link
Member

would also need backporting to v22 and up - cc @PVince81

@nickvergessen nickvergessen mentioned this pull request Feb 11, 2022
Merged
@AndyScherzinger AndyScherzinger linked an issue Feb 15, 2022 that may be closed by this pull request
Timed-based background jobs #30273
Closed
@PVince81
Copy link
Member

@nickvergessen can you update the docs for devs ?

This was referenced Feb 18, 2022
Closed
Closed
Closed
Closed
@juliusknorr juliusknorr mentioned this pull request Feb 18, 2022
Closed
11 tasks
@nickvergessen nickvergessen mentioned this pull request Feb 18, 2022
Closed
@nickvergessen
Copy link
Member Author

/backport to stable23

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 22, 2022
Merged
@nickvergessen
Copy link
Member Author

can you update the docs for devs ?

nextcloud/documentation#8087

@juliusknorr juliusknorr mentioned this pull request Mar 10, 2022
Closed
39 tasks
@pneuschwander pneuschwander mentioned this pull request Apr 24, 2022
Closed
8 tasks
@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@blizzz blizzz Awaiting requested review from blizzz

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@nickvergessen nickvergessen

Labels
4. to release Ready to be released and/or waiting for tests to finish performance 🚀 technical debt
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

Timed-based background jobs
6 participants
@nickvergessen @PVince81 @szaimen @AndyScherzinger @ChristophWurst @miaulalala