Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the file's mtime from the headers in bulk upload #30485

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Set the file's mtime from the headers in bulk upload #30485

merged 1 commit into from
Jan 12, 2022

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jan 4, 2022

The mtime was not set after the file creation, which would override the mtime of the file and lead to mtime change on the local file system of the users.

Fix #30473

@artonge artonge self-assigned this Jan 4, 2022
@artonge
Copy link
Contributor Author

artonge commented Jan 4, 2022

/backport to stable23

@artonge artonge modified the milestones: Nextcloud 23.0.1, Nextcloud 24 Jan 4, 2022
@artonge artonge force-pushed the fix/correctly_set_the_mtime_in_bulk_upload branch from e7a6c43 to 43a9632 Compare January 4, 2022 16:48
@artonge artonge force-pushed the fix/correctly_set_the_mtime_in_bulk_upload branch 6 times, most recently from 7253dd7 to bdf5c1f Compare January 5, 2022 11:54
@artonge artonge requested a review from juliusknorr January 5, 2022 11:55
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 6, 2022
@artonge
Copy link
Contributor Author

artonge commented Jan 6, 2022

Friendly ping to have this merged :)

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2022
Merged
6 tasks
@skjnldsv skjnldsv changed the title Set the file's mtime from the headers in bulk upload [stable23] Set the file's mtime from the headers in bulk upload Jan 7, 2022
mgallien
mgallien approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine for me
thanks a lot !

@artonge
Copy link
Contributor Author

artonge commented Jan 7, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the fix/correctly_set_the_mtime_in_bulk_upload branch from bdf5c1f to 492bab7 Compare January 7, 2022 12:37
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 8, 2022
@skjnldsv
Copy link
Member

skjnldsv commented Jan 8, 2022

php cs fails

@artonge
Copy link
Contributor Author

artonge commented Jan 10, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the fix/correctly_set_the_mtime_in_bulk_upload branch from 492bab7 to 3821686 Compare January 10, 2022 15:14
@artonge
Copy link
Contributor Author

artonge commented Jan 10, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the fix/correctly_set_the_mtime_in_bulk_upload branch from 3821686 to e9c99de Compare January 10, 2022 16:00
@artonge artonge force-pushed the fix/correctly_set_the_mtime_in_bulk_upload branch from e9c99de to 3606434 Compare January 10, 2022 17:58
@artonge artonge force-pushed the fix/correctly_set_the_mtime_in_bulk_upload branch 2 times, most recently from b3626cf to 1a47519 Compare January 11, 2022 09:59
@artonge artonge force-pushed the fix/correctly_set_the_mtime_in_bulk_upload branch 3 times, most recently from 4e6fdeb to 7b82526 Compare January 11, 2022 13:36
@artonge artonge force-pushed the fix/correctly_set_the_mtime_in_bulk_upload branch from 7b82526 to 69b8044 Compare January 11, 2022 16:10
@artonge artonge merged commit 55cb608 into master Jan 12, 2022
@artonge artonge deleted the fix/correctly_set_the_mtime_in_bulk_upload branch January 12, 2022 10:57
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 12, 2022
Merged
@solracsf solracsf mentioned this pull request Mar 11, 2022
Closed
8 tasks
@PhilippSchlesinger PhilippSchlesinger mentioned this pull request Mar 18, 2022
Closed
@rumplin
Copy link

rumplin commented Apr 1, 2022

It's not fixed for me, and also other users - look at comments for #30473

@driehle
Copy link

driehle commented Apr 1, 2022

These all seem to be related:

@joshtrichards joshtrichards mentioned this pull request Sep 16, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@artonge artonge

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: dav feature: filesystem
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

Timestamp issue with Nextcloud 23.0
6 participants
@artonge @skjnldsv @rumplin @driehle @mgallien @juliusknorr