Explicitly cast char in the query builder #30471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
nickvergessen,
skjnldsv,
a team and
CarlSchwan
and removed request for
a team
CarlSchwan
reviewed
Jan 3, 2022
lib/private/DB/QueryBuilder/ExpressionBuilder/MySqlExpressionBuilder.php
Show resolved
Hide resolved
lib/private/DB/QueryBuilder/ExpressionBuilder/MySqlExpressionBuilder.php
Show resolved
Hide resolved
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
enh/cast-char-mysql
branch
from
94f7ddd to
a169ca3
Compare
Signed-off-by: Joas Schilling <[email protected]>
|
Thanks for the follow up fix 👍 |
nickvergessen
approved these changes
Jan 11, 2022
skjnldsv
approved these changes
Jan 20, 2022
|
Failure seems unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a query with a cast method is built, it should also result in an actual CAST function call in the sql query, as that may allow the query to make proper use of indexes as found in nextcloud/deck#3497
Now ideally we should allow casting other types as well, however automatically mapping from the parameter type does not work globally for PARAM_INT as for the CAST there would be two separate types (UNSIGNED/SIGNED)