-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an API for calendar providers #28970
Conversation
} | ||
|
||
public function setTimerangeStart(\DateTime $startTime): void { | ||
$this->options['timerange']['start'] = $startTime; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you want to initialize options with an empty array otherwise you access an offset of null
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timerange is not initialized in the constructor
Is this ready for a final review? :) |
d0269da
to
efc762e
Compare
@miaulalala please add the deprecations to #27846 |
This comment has been minimized.
This comment has been minimized.
efc762e
to
dfe4c6c
Compare
dfe4c6c
to
116140b
Compare
116140b
to
d5025ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look clean
d5025ad
to
41d5841
Compare
41d5841
to
767e518
Compare
Signed-off-by: Anna Larch <[email protected]> Signed-off-by: Christoph Wurst <[email protected]>
767e518
to
a58d1e6
Compare
Right now user calendars are preemptively loaded in every request. This comes with two downsides
This flips the logic so that calendar back-end apps (mainly the dav app but possibly other "virtual" calendars like in deck) register that they provide calendars. Then, when calendars are needed, we ask all the registered providers for the calendars of the given principal, the providers give back a list and that list can be used for the queries.
This means we
Todo
Follow-up tasks
Required for nextcloud/calendar#3477