Fix trashbin files view sticky action bar #28754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Thanks for the fix!
Seems to work :)
single command to try
docker run \
-e SERVER_BRANCH=Simounet:fix/files-trashbin-action-sticky-bar \
-p 127.0.0.1:8443:443 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest
For further infos see https://github.com/szaimen/nextcloud-easy-test#nextcloud-easy-test-instance
szaimen
added
3. to review
szaimen
requested review from
marcoambrosini,
a team,
juliusknorr,
artonge and
skjnldsv
and removed request for
a team
artonge
approved these changes
Sep 9, 2021
|
DCO, then good to merge :) |
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
Signed-off-by: Simounet <[email protected]>
Simounet
force-pushed
the
fix/files-trashbin-action-sticky-bar
branch
from
9e0b01a to
ce570d0
Compare
szaimen
added
4. to release
This was referenced Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
It's a simple quick fix for the action bar of the trashbin view. When you selected some files, the sticky position wasn't activated on scroll and you had to go to the top to have access to the action menu.
Have a nice day.