Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send attendence links to required and optinal attendees of an event without an RSVP #28692

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

miaulalala
Copy link
Contributor

To compensate for the missing RSVP from Mail Clients like Apple Mail and Thunderbird, also look at the role of the attendee to determine if they should receive a link for the event.

Fixes #21189

@miaulalala miaulalala added bug 2. developing Work in progress papercut Annoying recurring issue with possibly simple fix. labels Sep 1, 2021
@miaulalala miaulalala self-assigned this Sep 1, 2021
@miaulalala
Copy link
Contributor Author

@ChristophWurst I'm not sure if adding the OPT-PARTICIPANT ROLE to the check would be beneficial. What do you think?

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But remove the unrelated new file :)

apps/dav/lib/CalDAV/Schedule/IMipPlugin.php Outdated Show resolved Hide resolved
@ChristophWurst
Copy link
Member

@ChristophWurst I'm not sure if adding the OPT-PARTICIPANT ROLE to the check would be beneficial. What do you think?

so that optional participants also get an invite when no RSVP is set?

@miaulalala miaulalala force-pushed the enh/send-invitation-to-req-participants branch from 02b7fe2 to f5b287a Compare September 2, 2021 08:39
@miaulalala
Copy link
Contributor Author

@ChristophWurst yes - I'm not sure if this is neccessary or even wanted, but it makes sense to me.

@ChristophWurst
Copy link
Member

some insights on the seemingly random psalm security check failure

Psalm dev-master@eb973ab2e1877845c74d65a9c6064fda9e34375c passes
Psalm dev-master@a655ca81c15e3b3fdc9c8c55a04d9f036c897b16 fails

@miaulalala miaulalala force-pushed the enh/send-invitation-to-req-participants branch from 06cca75 to 56cc01c Compare September 3, 2021 12:49
@ChristophWurst ChristophWurst changed the title Send Invitation to Attendees with ROLE=REQ-PARTICIPANT Send attendence links to required and optinal attendees of an event without an RSVP Sep 3, 2021
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works

@ChristophWurst
Copy link
Member

/backport to stable22

@ChristophWurst
Copy link
Member

/backport to stable21

@ChristophWurst
Copy link
Member

/backport to stable20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar invitation accept/decline buttons missing
3 participants