-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NMC-533 Set new folder name inline #28645
Conversation
…ment creation Signed-off-by: Kavita Sonawane <[email protected]>
96e4058
to
7e29bd1
Compare
Signed-off-by: Kavita Sonawane <[email protected]>
Signed-off-by: Kavita Sonawane <[email protected]>
@TSI-kavitasonawane The folder changes works great. But the file one is more subtle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
Also, JSUnit fails: TOTAL: 6 FAILED, 809 SUCCESS
1) sets default text in field
OCA.Files.NewFileMenu New file/folder
Expected 0 to equal 2.
at Object.<anonymous> (apps/files/tests/js/newfilemenuSpec.js:73:26)
Expected undefined to equal 'New folder'.
at Object.<anonymous> (apps/files/tests/js/newfilemenuSpec.js:74:25)
2) prevents entering invalid file names
OCA.Files.NewFileMenu New file/folder
Expected false to equal true.
at Object.<anonymous> (apps/files/tests/js/newfilemenuSpec.js:81:42)
3) prevents entering file names that already exist
OCA.Files.NewFileMenu New file/folder
Expected false to equal true.
at Object.<anonymous> (apps/files/tests/js/newfilemenuSpec.js:89:42)
4) creates directory when clicking on create directory field
OCA.Files.NewFileMenu New file/folder
Expected 'New folder' to equal 'some folder'.
at Object.<anonymous> (apps/files/tests/js/newfilemenuSpec.js:99:51)
5) calls action handler when clicking on custom item
OCA.Files.NewFileMenu custom entries
Expected 'New text file.txt' to equal 'some name'.
at Object.<anonymous> (apps/files/tests/js/newfilemenuSpec.js:144:42)
6) switching fields removes the previous form
OCA.Files.NewFileMenu custom entries
Expected 0 to equal 1.
at Object.<anonymous> (apps/files/tests/js/newfilemenuSpec.js:148:41) |
Signed-off-by: Kavita Sonawane <[email protected]>
Signed-off-by: Kavita Sonawane <[email protected]>
Jsunit needs to be adapted again and tabs indent is still not fixed :) |
100% Agree @juliushaertl |
Filed an issue about it in #31414 |
Close #28669
Add button folder creation changes:
Add button text document creation changes: