Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 SSE KMS key and bucket key encryption #28601

Closed
wants to merge 1 commit into from

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 26, 2021

Originally proposed by @tsdicloud this is the rebased version of #26899 with pulling the changes from https://github.com/nextmcloud/server/compare/master..s3fragment without the already merged parts from #27877

@juliusknorr juliusknorr added 3. to review Waiting for reviews enhancement feature: object storage pending documentation This pull request needs an associated documentation update labels Aug 27, 2021
@juliusknorr juliusknorr added this to the Nextcloud 23 milestone Aug 27, 2021
@juliusknorr juliusknorr changed the title Add S3 SSE KMS key and bucketked encryption Add S3 SSE KMS key and bucket key encryption Aug 27, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 21, 2021
@juliusknorr
Copy link
Member Author

🏓 for review

@@ -55,7 +60,7 @@ public function readObject($urn) {
'Bucket' => $this->bucket,
'Key' => $urn,
'Range' => 'bytes=' . $range,
]);
] + $this->getSseKmsGetParameters());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SseKmsPutParameters is placed under a config property, SseKmsGetParameters is not, is this right?

@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
@blizzz blizzz mentioned this pull request Sep 6, 2022
@blizzz blizzz mentioned this pull request Sep 9, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
@juliusknorr
Copy link
Member Author

Closing this for now as there is no current demand. This can be picked up to finish anytime of course.

@skjnldsv skjnldsv removed this from the Nextcloud 27 milestone Mar 2, 2023
@juliusknorr juliusknorr removed the pending documentation This pull request needs an associated documentation update label Jun 8, 2023
@skjnldsv skjnldsv deleted the enh/s3-sse-kms branch March 14, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants