Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dark theme in file exists dialog #28101

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Fix dark theme in file exists dialog #28101

merged 1 commit into from
Jul 22, 2021

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jul 21, 2021 •
edited
Loading

Fix #22748

Before After
image image

Signed-off-by: szaimen [email protected]

@szaimen szaimen added 3. to review Waiting for reviews bug design Design, UI, UX, etc. labels Jul 21, 2021
@szaimen szaimen added this to the Nextcloud 23 milestone Jul 21, 2021
@szaimen
Copy link
Contributor Author

szaimen commented Jul 21, 2021

Failing test is unrelated

@szaimen
Copy link
Contributor Author

szaimen commented Jul 22, 2021

/backport to stable22

@szaimen
Copy link
Contributor Author

szaimen commented Jul 22, 2021

/backport to stable21

@szaimen
Copy link
Contributor Author

szaimen commented Jul 22, 2021

/backport to stable20

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 22, 2021
julien-nc
julien-nc approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@szaimen
Copy link
Contributor Author

szaimen commented Jul 22, 2021 •
edited
Loading

Thanks! :) @eneiluj do you have force-merge rights?

@julien-nc
Copy link
Member

@szaimen Nowpe 😁

@szaimen
Copy link
Contributor Author

szaimen commented Jul 22, 2021

Nowpe 😁

Okay

@szaimen
Copy link
Contributor Author

szaimen commented Jul 22, 2021

Merging because failing test is unrelated

@szaimen szaimen merged commit dd4668f into master Jul 22, 2021
@szaimen szaimen deleted the fix/22748/fix-file-exists-dialog-dark-theme branch July 22, 2021 10:37
This was referenced Jul 22, 2021
Merged
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@julien-nc julien-nc julien-nc approved these changes

@Pytal Pytal Pytal approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.

Dark theme : black on black in file conflict popup
4 participants
@szaimen @julien-nc @artonge @Pytal