fix error when using CORS with no auth credentials #26852
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an
ApiController
withCORS
annotation, basic authentication is required. However, currently the following exception occurs when a request does not contain any authentication:In consultation with @nickvergessen , this PR fixes this by checking if
$user
and$pass
are not null before trying to login.Furthermore, I fixed an
Undefined index error
forPHP_AUTH_USER
andPHP_AUTH_PW
.I suggest backporting this to the stable branches.