Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .htaccess (php8+ and mod_lsapi) #26584

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Update .htaccess (php8+ and mod_lsapi) #26584

merged 2 commits into from
Aug 20, 2021

Conversation

solracsf
Copy link
Member

  • Add mod_lsapi (Cloudlinux) authorization headers
  • Add mod_php8 php_values
  • Reformating for better lisibilty

@solracsf solracsf added the 3. to review Waiting for reviews label Apr 16, 2021
@solracsf solracsf linked an issue Apr 16, 2021 that may be closed by this pull request
.htaccess Outdated Show resolved Hide resolved
@solracsf solracsf changed the title Update .htaccess (php8 and mod_lsapi) Update .htaccess (php8+ and mod_lsapi) Apr 21, 2021
@szaimen szaimen added this to the Nextcloud 23 milestone Jul 6, 2021
Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pytal
Copy link
Member

Pytal commented Jul 16, 2021

@acsfer lint error on CI, needs a

composer run-script cs:fix

- Add `mod_lsapi` (Cloudlinux) authorization headers
- Add `mod_php8` php_values
- Reformating for better lisibilty
@nickvergessen
Copy link
Member

rebased

@Pytal Pytal merged commit e2375a3 into master Aug 20, 2021
@Pytal Pytal deleted the update-htaccess branch August 20, 2021 21:25
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 20, 2021
@MichaIng
Copy link
Member

/backport to stable22

@ghost
Copy link

ghost commented Sep 14, 2021

/backport to stable22

Thank you!

@MichaIng
Copy link
Member

MichaIng commented Sep 14, 2021

If I'm not mistaken, also NC21 has PHP8.0 support, doesn't it?

EDIT: Yes it is: https://github.com/nextcloud/server/blob/stable21/lib/versioncheck.php
NC20 not yet: https://github.com/nextcloud/server/blob/stable20/lib/versioncheck.php

@MichaIng
Copy link
Member

/backport to stable21

@ghost
Copy link

ghost commented Sep 14, 2021

If I'm not mistaken, also NC21 has PHP8.0 support, doesn't it?

EDIT: Yes it is: https://github.com/nextcloud/server/blob/stable21/lib/versioncheck.php
NC20 not yet: https://github.com/nextcloud/server/blob/stable20/lib/versioncheck.php

Yes it dose.

@MichaIng
Copy link
Member

I mean also without PHP8.0 support, the mod_lsapi support may still be worth it and the mod_php condition does not hurt in any way and could also manually be removed from the commit. But since half of the purpose is gone, I'll leave it up to others to create that backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP8 in the .htaccess
8 participants