Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set mimetype for objects uploaded to object storages #26575

Merged
merged 1 commit into from
Apr 21, 2021
Merged

set mimetype for objects uploaded to object storages #26575

merged 1 commit into from
Apr 21, 2021

Conversation

icewind1991
Copy link
Member

Fixes #19487

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Apr 15, 2021
@icewind1991 icewind1991 added this to the Nextcloud 22 milestone Apr 15, 2021
PVince81
PVince81 approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine 👍

Assuming you retested all those storages already.
Will the trait method interface change affect/break existing third party implementation ?

@icewind1991
Copy link
Member Author

Will the trait method interface change affect/break existing third party implementation ?

Object storages can't be implemented by apps at the moment

@kesselb
Copy link
Contributor

kesselb commented Apr 20, 2021

image

Tested with minio. Content-Type is now set 👍

@kesselb kesselb merged commit d1db7ab into master Apr 21, 2021
@kesselb kesselb deleted the s3-set-mimetype branch April 21, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@PVince81 PVince81 PVince81 approved these changes

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.

Files uploaded to S3 external storage given 'Content-type: application/octet-stream', always
4 participants
@icewind1991 @kesselb @rullzer @PVince81