-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't throw an exception when php-xml is missing #2619
Don't throw an exception when php-xml is missing #2619
Conversation
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ringmaster, @LukasReschke and @bartv2 to be potential reviewers. |
I guess this is because the compatibility check is performed later? Would an alternative be to move the compatibility check higher? |
Well the check uses language, therefor requires the user session, therefor session apps need to be loaded already => 🙈 |
On the otherhand this stuff doesnt happen accidentially. So I guess an english only message would also be fine. |
I would be fine by not having this message translated. |
@nickvergessen Could you fix this? |
Why do we even initialize a session if the instance is not yet installed. Maybe we could fix this the other way around. |
Sorry that will be way more work. Feel free to do that. It needs major changes in base.php and the Setup class. |
@LukasReschke I guess we can also backport this later, so up to you if 11 or not
Fix #2180